[SAGE-795] Transactions table hover behavior #1578
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
QuintonJason
changed the title
pixelflips
approved these changes
Sep 7, 2022
goodwinchris
approved these changes
Sep 8, 2022
|
Q: did we test this with any kind of modal or overlay open to make sure it sits below those? |
philschanely
approved these changes
Sep 8, 2022
There was a problem hiding this comment.
Seconding @goodwinchris the Contacts page is another good place to check any changes to z-index in Table, Dropdown, Drawer, and Modal, especially as the page scrolls and the application nav/header overlaps with such elements.
QuintonJason
force-pushed
the
SAGE-795/qj-transactions-page-dropdown-behavior
branch
from
436d626
to
2b0cf04
Compare
|
Did checking around and there are no other issues. The contact specifically calls out a |
QuintonJason
force-pushed
the
SAGE-795/qj-transactions-page-dropdown-behavior
branch
from
2b0cf04
to
53d11f5
Compare
QuintonJason
deleted the
SAGE-795/qj-transactions-page-dropdown-behavior
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Screenshots
Testing in
sage-libVerify that the tables not longer have a
z-indexonsage-table-wrapperTesting in
kajabi-productsClick on Sales > Payments > Click the dropdown > then click on a field in the table to close the dropdown
z-indexfromSageTable.Related
Closes SAGE-795