Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SAGE-797]: Form element spacing and color adjustments spec alignment #1579

Merged
merged 12 commits into from
Sep 8, 2022

Conversation

pixelflips
Copy link
Member

@pixelflips pixelflips commented Sep 7, 2022

Description

Label, message, and colors for the following form components need to be updated for better alignment with design specs.

  • Form input
  • Form select
  • Form textarea

The color changes are to better help differentiate when a form input is displaying placeholder text vs containing actual inputted text.

Screenshots

FORM INPUT:

Before After
Label Screen Shot 2022-09-07 at 2 43 01 PM Screen Shot 2022-09-07 at 2 43 26 PM
Message Screen Shot 2022-09-07 at 2 53 37 PM Screen Shot 2022-09-07 at 2 53 52 PM
Color (when text entered) Screen Shot 2022-09-07 at 2 55 15 PM Screen Shot 2022-09-07 at 2 55 39 PM

FORM SELECT:

Before After
Label Screen Shot 2022-09-07 at 3 04 52 PM Screen Shot 2022-09-07 at 3 05 14 PM
Color (when text entered) Screen Shot 2022-09-07 at 3 06 18 PM Screen Shot 2022-09-07 at 3 06 31 PM

FORM TEXTAREA:

Before After
Label Screen Shot 2022-09-07 at 3 22 08 PM Screen Shot 2022-09-07 at 3 24 13 PM
Color (when text entered) Screen Shot 2022-09-07 at 3 30 48 PM Screen Shot 2022-09-07 at 3 31 20 PM

KP EXAMPLE:

Before After
Screen Shot 2022-09-07 at 4 08 43 PM Screen Shot 2022-09-07 at 4 07 13 PM

Testing in sage-lib

  • Navigate to form elements outlined above
  • Verify spacing and color adjustments align w/ design spec

Testing in kajabi-products

  1. (**LOW) Updates spacing and colors related to form elements to match design specs. Styling only updates.

Related

https://kajabi.atlassian.net/browse/SAGE-797

@pixelflips pixelflips added the improvement Improve on existing work label Sep 7, 2022
@pixelflips pixelflips self-assigned this Sep 7, 2022
@pixelflips pixelflips marked this pull request as ready for review September 7, 2022 23:13
@pixelflips pixelflips requested review from a team and cameronsimony September 7, 2022 23:14
@ju-Skinner ju-Skinner requested a review from a team September 8, 2022 15:34
@pixelflips pixelflips force-pushed the SAGE-797_pl-form-element-adjustments branch from ba4bdd5 to 35b60a6 Compare September 8, 2022 15:52
Copy link

@cameronsimony cameronsimony left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sweet! looks much better

@pixelflips pixelflips force-pushed the SAGE-797_pl-form-element-adjustments branch from 35b60a6 to 19e2561 Compare September 8, 2022 18:21
@pixelflips pixelflips force-pushed the SAGE-797_pl-form-element-adjustments branch from 19e2561 to 8f92b10 Compare September 8, 2022 18:27
@pixelflips pixelflips merged commit cf8ad09 into develop Sep 8, 2022
@pixelflips pixelflips mentioned this pull request Sep 8, 2022
1 task
@pixelflips pixelflips deleted the SAGE-797_pl-form-element-adjustments branch September 8, 2022 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improve on existing work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants