-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SAGE-797]: Form element spacing and color adjustments spec alignment #1579
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ju-Skinner
approved these changes
Sep 8, 2022
philschanely
approved these changes
Sep 8, 2022
pixelflips
force-pushed
the
SAGE-797_pl-form-element-adjustments
branch
from
September 8, 2022 15:52
ba4bdd5
to
35b60a6
Compare
goodwinchris
approved these changes
Sep 8, 2022
cameronsimony
approved these changes
Sep 8, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sweet! looks much better
pixelflips
force-pushed
the
SAGE-797_pl-form-element-adjustments
branch
from
September 8, 2022 18:21
35b60a6
to
19e2561
Compare
- @kajabi/sage@5.3.0 - @kajabi/sage-assets@1.0.4 - @kajabi/sage-packs@1.0.4 - @kajabi/sage-react@1.2.0 - @kajabi/sage-system@1.0.1
- @kajabi/sage@5.4.0 - @kajabi/sage-assets@1.1.0 - @kajabi/sage-packs@1.0.5 - @kajabi/sage-react@1.3.0 - @kajabi/sage-system@1.1.0
pixelflips
force-pushed
the
SAGE-797_pl-form-element-adjustments
branch
from
September 8, 2022 18:27
19e2561
to
8f92b10
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Label, message, and colors for the following form components need to be updated for better alignment with design specs.
The color changes are to better help differentiate when a form input is displaying placeholder text vs containing actual inputted text.
Screenshots
FORM INPUT:
FORM SELECT:
FORM TEXTAREA:
KP EXAMPLE:
Testing in
sage-lib
Testing in
kajabi-products
Related
https://kajabi.atlassian.net/browse/SAGE-797