[SAGE-144]: Add NilClass to all optional props (Rails) #1577
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pixelflips
added
improvement
philschanely
approved these changes
Sep 6, 2022
ju-Skinner
approved these changes
Sep 8, 2022
pixelflips
force-pushed
the
SAGE-144_pl-nil-on-optional-props-rails
branch
from
8a477b8
to
3db65a2
Compare
goodwinchris
reviewed
Sep 8, 2022
goodwinchris
approved these changes
Sep 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When iterating through creating components within a loop in Rails optional properties benefit from including nil as a possible value. This way a default of nil can be provided while also allowing additional values to be set conditionally within the loop.
This PR adds
NilClassto all optional props for the rails components.Screenshots
No visual changes.
Testing in
sage-libCheck files changed and then try passing
nilto any of the updated properties in a preview fileTesting in
kajabi-productsNilClassto all optional props. No effect is expected on KP.Related
https://kajabi.atlassian.net/browse/SAGE-144