Table: Ensure responsive: false turns off responsive features

[philschanely]

Description

This PR patches some faulty logic within SageTable to ensure that when users set responsive: false the responsive features are indeed disabled.

This fix relates to how component.responsive.present? evaluates an explicit false value. We want the tables to be responsive by default. Users should be able to override this by setting responsive: false. This table shows how the prior logic was evaluating values provided compared to the new logic.

Value provided	Original is_responsive = component.responsive.present? ? component.responsive : true	New is_responsive = component.responsive != false
None/nil	👍 true	👍 true
true	👍 true	👍 true
false	❌ true	👍 false

The issue seemed to be that when false was provided component.responsive.present? still resolved to false so the ternary would return true where we though it would return component.responsive.

Screenshots

	Before	After
responsive: true or not set	👍	👍
responsive: false	❌	👍

Testing in sage-lib

See http://localhost:4000/pages/component/table?tab=preview for no regressions.

Testing in kajabi-products

1. (LOW) Fix SageTable so that responsive: false has the intended effect of disabling sideways scrolling.

Related

https://kajabi.atlassian.net/browse/DSS-158

[philschanely]

@ju-Skinner would you be willing to give this an early review? Any other ideas for how to make this most readable?

[philschanely]

@ju-Skinner thanks for early feedback through Slack! 🙌

[pixelflips]

LGTM! 👍🏼

[teenwolfblitzer]

👍 LGTM! Interestingly, while testing this in KP it seems the main Offers table overflows at certain screen sizes. Appears to be an existing issue.