Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Table: Ensure responsive: false turns off responsive features #1611

Merged
merged 2 commits into from
Oct 6, 2022
Merged

Table: Ensure responsive: false turns off responsive features #1611

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
574f248
fix(table): ensure `responsive: false` turns off responsive features …
philschanely Oct 3, 2022
cf861ea
feat(table): improve readability of `is_responsive`
philschanely Oct 4, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion docs/lib/sage_rails/app/views/sage_components/_sage_table.html.erb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,8 @@
<%
is_responsive = component.responsive.present? ? component.responsive : true
is_responsive = true
if component&.responsive == false
is_responsive = false
end
%>
<div class="
sage-table-wrapper
Expand Down