Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add required prop to the sage-lib Select component #1633

Merged
merged 2 commits into from
Nov 11, 2022
Merged

Add required prop to the sage-lib Select component #1633

merged 2 commits into from
Nov 11, 2022

Conversation

theUndeadShred
Copy link
Contributor

Description

Adds the "required" prop to the sage-lib Select component.
Allows for management of forms using the Select component via the FormValidation API.

No visual updates.
No impact to existing implementation as the default value is false.

Testing in sage-lib

N/A

Testing in kajabi-products

  1. (LOW/MEDIUM/HIGH/BREAKING) Description of the change and its impact with QA as the audience.
    • One more examples of the component in use to either test the change or verify the change has not had adverse effects.

Related

@theUndeadShred theUndeadShred added the enhancement New feature or request label Nov 8, 2022
@theUndeadShred theUndeadShred self-assigned this Nov 8, 2022
@teenwolfblitzer teenwolfblitzer requested review from a team November 9, 2022 17:30
@pixelflips
Copy link
Member

@theUndeadShred I am seeing changes to some files that I don't believe relate to your updates. Not sure what's up or if those are on purpose. Happy to review, but just let me know.

@aperez-kajabi @teenwolfblitzer
feat: adding required prop to sage-react select component
cf34b25 
the new prop is optional and defaults to 'false'
@aperez-kajabi @teenwolfblitzer
feat: adding required prop to sage-react select component
4293194 
the new prop is optional and defaults to 'false'
teenwolfblitzer
teenwolfblitzer approved these changes Nov 10, 2022
View reviewed changes
Copy link
Member

@teenwolfblitzer teenwolfblitzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM!

pixelflips
pixelflips approved these changes Nov 10, 2022
View reviewed changes
Copy link
Member

@pixelflips pixelflips left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Nice work!

@theUndeadShred theUndeadShred merged commit 6ee50fc into develop Nov 11, 2022
@monicawheeler monicawheeler deleted the AddRequiredPropToSelect branch December 6, 2022 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pixelflips pixelflips pixelflips approved these changes

@teenwolfblitzer teenwolfblitzer teenwolfblitzer approved these changes

Assignees

@theUndeadShred theUndeadShred

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@theUndeadShred @pixelflips @teenwolfblitzer @aperez-kajabi