Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add required prop to the sage-lib Select component #1633

Merged
merged 2 commits into from
Nov 11, 2022
Merged

Add required prop to the sage-lib Select component #1633

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cf34b25
feat: adding required prop to sage-react select component
aperez-kajabi Nov 8, 2022
4293194
feat: adding required prop to sage-react select component
aperez-kajabi Nov 8, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions packages/sage-react/lib/Select/Select.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ export const Select = ({
message,
onChange,
options,
required,
value,
...rest
}) => {
Expand Down Expand Up @@ -66,6 +67,7 @@ export const Select = ({
placeholder={label}
value={value}
disabled={disabled}
required={required}
{...rest}
>
{(label && includeLabelInOptions) && <option label={label} />}
Expand Down Expand Up @@ -96,6 +98,7 @@ Select.defaultProps = {
message: null,
onChange: (evt) => evt,
options: [],
required: false,
value: '',
};

Expand Down Expand Up @@ -134,5 +137,6 @@ Select.propTypes = {
}),
]),
),
required: PropTypes.bool,
value: PropTypes.string,
};