fix(dropdown): resolve sentry errors in positionElement #1883
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pixelflips
approved these changes
May 6, 2024
anechol
approved these changes
May 6, 2024
ju-Skinner
approved these changes
May 6, 2024
Merged
pixelflips
added a commit
that referenced
this pull request
May 7, 2024
* fix(switch): correct spacing value * feat(icons): Update icon font (v.27) (#1884) * feat(icons): add new icons to _icon.scss * feat(icons): add new icons to sage_tokens.rb * feat(icons): add new icons to icons.js * feat(icons): increment cdn-version variable * fix(dropdown): resolve sentry errors in positionElement (#1883) * fix(dropdown): resolve sentry error in positionElement * test(dropdown): remove trailing spaces * fix(dropdown): remove trailing whitespace --------- Co-authored-by: Quinton Jason <quinton.jason@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Resolve sentry error
Currently unable to check visually but pushing this fix as it doesn't introduce a breaking change
Testing in
sage-libUnable to check in sage
Testing in
kajabi-productsUnable to check in
kp, pushing non-breaking change then monitoringRelated
Closes #607