Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(icons): Update icon font (v.27) #1884

Merged
merged 4 commits into from
May 6, 2024

Conversation

pixelflips
Copy link
Member

Description

Updates the Sage fonts and adds 4 new icons to the system:

  • comment-no
  • more-menu
  • more-menu-filled

Screenshots

Name
comment-no Screenshot 2024-05-06 at 10 35 07 AM
more-menu Screenshot 2024-05-06 at 10 35 22 AM
more-menu-filled Screenshot 2024-05-06 at 10 35 32 AM

Testing in sage-lib

Docs Site:

  1. Navigate to icons
  2. Verify new icons are added to the system
  3. Verify all icons are rendering as expected
  4. Verify Sage font is served from the /v27 directory from CDN (Network panel in dev tools)

Storybook:

  1. Navigate to icon card
  2. Verify new icons are available in the drop-down list
  3. Verify all icons are rendering as expected

Testing in kajabi-products

  1. (LOW) Updated icon font w/ 3 new icons (v27). No KP impact is expected.

Related

https://kajabi.atlassian.net/browse/DSS-608

@pixelflips pixelflips self-assigned this May 6, 2024
@pixelflips pixelflips marked this pull request as ready for review May 6, 2024 17:42
@pixelflips pixelflips requested a review from a team May 6, 2024 17:42
@monicawheeler monicawheeler self-requested a review May 6, 2024 17:50
@pixelflips pixelflips requested a review from a team May 6, 2024 17:54
@pixelflips pixelflips merged commit 902990c into develop May 6, 2024
5 checks passed
@pixelflips pixelflips deleted the feat/pl-update-icon-font-v27 branch May 6, 2024 18:01
@pixelflips pixelflips mentioned this pull request May 6, 2024
pixelflips added a commit that referenced this pull request May 7, 2024
* fix(switch): correct spacing value

* feat(icons): Update icon font (v.27) (#1884)

* feat(icons): add new icons to _icon.scss

* feat(icons): add new icons to sage_tokens.rb

* feat(icons): add new icons to icons.js

* feat(icons): increment cdn-version variable

* fix(dropdown): resolve sentry errors in positionElement (#1883)

* fix(dropdown): resolve sentry error in positionElement

* test(dropdown): remove trailing spaces

* fix(dropdown): remove trailing whitespace

---------

Co-authored-by: Quinton Jason <quinton.jason@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants