Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

07e8e-Kaisho.svg is a muddle #296

Closed
benkasminbullock opened this issue Apr 13, 2022 · 2 comments
Closed

07e8e-Kaisho.svg is a muddle #296

benkasminbullock opened this issue Apr 13, 2022 · 2 comments
Labels
Numbering The numerical labels on strokes Stroke order The order of strokes in the character

Comments

@benkasminbullock
Copy link
Member

The strokes are out of order as can be seen where the numbers and strokes should be the same colour:
07e8e-Kaisho
benkasminbullock added a commit that referenced this issue Apr 13, 2022
@benkasminbullock
Change path type of 非 first stroke from ㇒ to ㇓
d222352 
For some reason the left vertical of 非 had stroke type ㇒ in
KanjiVG. Given the error I made with 心 and 灬 I did check against the
CJK stroke type documentation but I cannot see any evidence why ㇒ is
the correct stroke path, so I'm changing all of these to ㇓. 非 is
also used as a "visual" subelement of 韭 (nira), but almost all of
these nira elements, except two which seem to contain errors, see

#296

and

#297,

have a vertical stroke, so those are all unchanged.

This should fix

#286
@benkasminbullock benkasminbullock mentioned this issue Apr 13, 2022
Merged
@benkasminbullock
Copy link
Member Author

#301 should fix this.

@benkasminbullock
Copy link
Member Author

Here's a visual for a quick check. The stroke number labels and colours of strokes should agree.

7e8e-after

@benkasminbullock benkasminbullock added Numbering The numerical labels on strokes Stroke order The order of strokes in the character labels Apr 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Numbering The numerical labels on strokes Stroke order The order of strokes in the character
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@benkasminbullock