Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

07e96-Kaisho.svg has strokes 4 and 5 swapped #297

Closed
benkasminbullock opened this issue Apr 13, 2022 · 2 comments
Closed

07e96-Kaisho.svg has strokes 4 and 5 swapped #297

benkasminbullock opened this issue Apr 13, 2022 · 2 comments
Labels
Numbering The numerical labels on strokes Stroke order The order of strokes in the character

Comments

@benkasminbullock
Copy link
Member

benkasminbullock commented Apr 13, 2022 •
edited
Loading

07e96-Kaisho

Also the type on stroke 12 is ㇒ which is inconsistent with all the other 韭 elements, which use a vertical for this, and the final stroke has no number.
benkasminbullock added a commit that referenced this issue Apr 13, 2022
@benkasminbullock
Change path type of 非 first stroke from ㇒ to ㇓
d222352 
For some reason the left vertical of 非 had stroke type ㇒ in
KanjiVG. Given the error I made with 心 and 灬 I did check against the
CJK stroke type documentation but I cannot see any evidence why ㇒ is
the correct stroke path, so I'm changing all of these to ㇓. 非 is
also used as a "visual" subelement of 韭 (nira), but almost all of
these nira elements, except two which seem to contain errors, see

#296

and

#297,

have a vertical stroke, so those are all unchanged.

This should fix

#286
@benkasminbullock benkasminbullock mentioned this issue Apr 13, 2022
Merged
@benkasminbullock
Copy link
Member Author

This website gives the order of the bottom strokes from left to right.

benkasminbullock added a commit that referenced this issue Apr 13, 2022
@benkasminbullock
Fix up 07e96-Kaisho.svg
41210e6 
See #297
@benkasminbullock benkasminbullock mentioned this issue Apr 13, 2022
Merged
@benkasminbullock
Copy link
Member Author

Here's a visual for a quick check:

7e96-after

@benkasminbullock benkasminbullock added Error Things which are definitely wrong Stroke order The order of strokes in the character Numbering The numerical labels on strokes and removed Error Things which are definitely wrong labels Apr 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Numbering The numerical labels on strokes Stroke order The order of strokes in the character
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@benkasminbullock