Radical fixes #288
Merged
Radical fixes #288
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See #287 for discussion
Also change original field on top element to be correct two boxes
The correct Kangxi radical for 0820a is 臼
This makes sure that the tradit radical has an element associated with it.
In the cases where no variant Nelson radical exists, change the value of kvg:radical to "general" from "tradit". The cases where a variant Nelson radical exists are unaltered.
The five files in this commit all have a general radical in the correct place plus a "nelson" radical in somewhere very unlikely, but which uses the same original element as the general radical. Although I don't have a copy of Nelson to check against, I'm fairly certain these are errors, since Nelson was at least consistent.
benkasminbullock
force-pushed
the
radical-fixes
branch
from
d23eeb2 to
0edae07
Compare
This adds missing cases of nelson or tradit to the kvg:radical field on the appropriate elements.
|
Jim Breen got back to me to say that Kanjidic uses the radicals from a reference called the JIS 漢字辞典 so I have to go and check that from the library or something. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes a lot of radicals after checking against Kanjidic. Where Kanjidic was different from KanjiVG, I also looked at Wiktionary and other sources. Five differences seemed to be errors in Kanjidic, which I've reported. The rest I've changed here. There are still a few discrepancies left.