Fix usu #290
Closed
Fix usu #290
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
06b43.svg and 063d2.svg contained incorrect stroke types, but their stroke order is actually the one required by issue 180. The other change in this commit is to add various missing elements on groups.
For the case that there is no HzFst file, explicitly swap the strokes around within the XML.
This commit just renames files to fix issue 190. HzFst are renamed to the plain file name, and the plain files with the stroke order error are renamed to HzLst.
See #287 for discussion
Also change original field on top element to be correct two boxes
The correct Kangxi radical for 0820a is 臼
This makes sure that the tradit radical has an element associated with it.
In the cases where no variant Nelson radical exists, change the value of kvg:radical to "general" from "tradit". The cases where a variant Nelson radical exists are unaltered.
The five files in this commit all have a general radical in the correct place plus a "nelson" radical in somewhere very unlikely, but which uses the same original element as the general radical. Although I don't have a copy of Nelson to check against, I'm fairly certain these are errors, since Nelson was at least consistent.
This adds missing cases of nelson or tradit to the kvg:radical field on the appropriate elements.
This kanji had its strokes muddled up, so I've hand-edited them into the correct order.
benkasminbullock
force-pushed
the
fix-usu
branch
from
78fb3fd to
d688036
Compare
|
This got into a huge mess somehow, Anyway instead of spending a lot of time trying to work out what happened, I'm closing this pull request, because it's easy enough to just check out the newest version of the master branch again and run the script again to fix all the problems. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #180 et al.