Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provide basic kamelet component config panel for unknown kamelet template id #1004

Closed
apupier opened this issue Apr 11, 2024 · 1 comment · Fixed by #1120
Closed

Provide basic kamelet component config panel for unknown kamelet template id #1004

apupier opened this issue Apr 11, 2024 · 1 comment · Fixed by #1120
Assignees
@lordrip
Labels
canvas/config-form Configuration form related issues enhancement New feature or request
Milestone
2.1.0

Comments

@apupier
Copy link
Member

apupier commented Apr 11, 2024 •
edited
Loading

Please describe the feature that you want to propose

When using a kamelet component, there is a config panel asking for several parameters, including the Template Id.

image

In case an unknown template if is provided, after close/reopen of the config panel, the kamelet is marked as unknown on the graphic and the config panel is showing only a very short list of parameters, especially missing the templateId

image

This is an important feature for custom kamelet which are not part of the catalog, awaiting that we can configure kamelets that users can pick outsid of the default catalog.
@apupier apupier added enhancement New feature or request canvas/config-form Configuration form related issues labels Apr 11, 2024
@lordrip
Copy link
Member

lordrip commented Apr 12, 2024

What we see is the To EIP parameters, without the URI field, since we can't recognize the kamelet from the catalog, we don't show properties for it. We could do special handling so we always show the kamelet component's parameters

@lordrip lordrip moved this from New to Backlog in Kanban Board Apr 16, 2024
@lordrip lordrip moved this from Backlog to New in Kanban Board May 20, 2024
@lordrip lordrip moved this from New to Todo in Kanban Board May 21, 2024
@lordrip lordrip added this to the 2.1.0 milestone May 28, 2024
@lordrip lordrip self-assigned this Jun 2, 2024
@lordrip lordrip moved this from Todo to In Review in Kanban Board Jun 2, 2024
lordrip added a commit to lordrip/kaoto that referenced this issue Jun 2, 2024
@lordrip
fix(CanvasForm): Provide basic schema for unknown Kamelets
4c25942 
Currently, when using the `kamelet` component, providing an unknown
Kamelet to Kaoto, this renders the basic `To` EIP configuration form.

This is not useful since then we can't provide the Kamelet's TemplateId
nor RouteId.

The fix is to fallback to the standard `Kamelet` component when passing
an unknown Kamelet to Kaoto.

fix: KaotoIO#1004
@lordrip lordrip mentioned this issue Jun 2, 2024
Merged
lordrip added a commit that referenced this issue Jun 3, 2024
@lordrip
fix(CanvasForm): Provide basic schema for unknown Kamelets
36d9020 
Currently, when using the `kamelet` component, providing an unknown
Kamelet to Kaoto, this renders the basic `To` EIP configuration form.

This is not useful since then we can't provide the Kamelet's TemplateId
nor RouteId.

The fix is to fallback to the standard `Kamelet` component when passing
an unknown Kamelet to Kaoto.

fix: #1004
@github-project-automation github-project-automation bot moved this from In Review to Done in Kanban Board Jun 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lordrip lordrip

Labels
canvas/config-form Configuration form related issues enhancement New feature or request
Projects
Kanban Board
Archived in project
Milestone
2.1.0
Development

Successfully merging a pull request may close this issue.

fix(CanvasForm): Provide basic schema for unknown Kamelets lordrip/kaoto
2 participants
@apupier @lordrip