fix(CanvasForm): Provide basic schema for unknown Kamelets #1120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, when using the `kamelet` component, providing an unknown Kamelet to Kaoto, this renders the basic `To` EIP configuration form. This is not useful since then we can't provide the Kamelet's TemplateId nor RouteId. The fix is to fallback to the standard `Kamelet` component when passing an unknown Kamelet to Kaoto. fix: KaotoIO#1004
apupier
approved these changes
Jun 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Currently, when using the
kameletcomponent, providing an unknown Kamelet to Kaoto, this renders the basicToEIP configuration form.This is not useful since then we can't provide the Kamelet's TemplateId nor RouteId.
Changes
The fix is to fallback to the standard
Kameletcomponent when passing an unknown Kamelet to Kaoto.fix: #1004