Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

How to organize the parts of the Kaoto UI for the VS Code extension #402

Closed
lhein opened this issue Nov 22, 2023 · 4 comments · Fixed by #549
Closed

How to organize the parts of the Kaoto UI for the VS Code extension #402

lhein opened this issue Nov 22, 2023 · 4 comments · Fixed by #549
Assignees
@lordrip
Labels
canvas/visualization Canvas-related issues enhancement New feature or request help wanted Extra attention is needed ui/ux This issue is about improving the UI / UX VS Code VS Code extension related issues
Milestone
2.0.0 TP1

Comments

@lhein
Copy link
Contributor

lhein commented Nov 22, 2023 •
edited
Loading

In the VS Code extension we will not have the left side nav bar that we have in the live environment. So the question will be how to organize the different parts of the UI then.

One idea would be to introduce top or bottom tabs for the different editors we have. That would be the visual designer, the beans editor and in future other editors like REST, Metadata, Errorhandlers etcs. I am wondering if we can find a way to combine beans, metadata, error handler into a single tab like "Configuration".

We had something similar in the Eclipse Fuse Tooling...

Image
@lhein lhein converted this from a draft issue Nov 22, 2023
@lhein lhein added this to the Polishing UI-UX post parity milestone Nov 22, 2023
@lhein lhein moved this from New to Todo in Kanban Board Nov 22, 2023
@lhein lhein moved this from Todo to Blocked in Kanban Board Nov 30, 2023
@lhein lhein added enhancement New feature or request canvas/visualization Canvas-related issues on hold Issues or pull requests that are waiting for something labels Nov 30, 2023
@lordrip lordrip moved this from Blocked to In Progress in Kanban Board Dec 4, 2023
@lordrip lordrip self-assigned this Dec 4, 2023
@lordrip lordrip added help wanted Extra attention is needed and removed on hold Issues or pull requests that are waiting for something labels Dec 4, 2023
lordrip added a commit to lordrip/kaoto that referenced this issue Dec 5, 2023
@lordrip
feat(vscode): Add Tabs for other editors
acd4629 
This commit adds tabs for the remaining editors, like the Beans editor and the Metadata editor for VSCode.

This is the first step towards having a better support for Camel entities

relates to: KaotoIO#402
@lordrip lordrip mentioned this issue Dec 5, 2023
Merged
@lordrip
Copy link
Member

lordrip commented Dec 5, 2023 •
edited by lhein
Loading

First iteration towards this: #509 -> Merged

@lhein lhein added the ui/ux This issue is about improving the UI / UX label Dec 5, 2023
lhein pushed a commit that referenced this issue Dec 5, 2023
@lordrip @lhein
feat(vscode): Add Tabs for other editors
f02b7da 
This commit adds tabs for the remaining editors, like the Beans editor and the Metadata editor for VSCode.

This is the first step towards having a better support for Camel entities

relates to: #402
@lhein
Copy link
Contributor Author

lhein commented Dec 7, 2023

After the first iteration 2 issues became evident.

  • when editing a Pipe you lose all the tabs once you click the tab for "Metadata" and you have to reopen the editor to get them back
  • when switching from Camel Route to Pipe editing and saving the initial route, the source file does not get updated to the latest state / still contains the Camel Route

@lhein lhein added the VS Code VS Code extension related issues label Dec 7, 2023
@lordrip
Copy link
Member

lordrip commented Dec 8, 2023

The first issue is being handled in: #534

@lordrip lordrip assigned lordrip and unassigned lordrip Dec 12, 2023
lordrip added a commit to lordrip/kaoto that referenced this issue Dec 12, 2023
@lordrip
fix(vscode): Fix VSCode switching integration type
8abecce 
Currently, when VSCode switch from one integration type to another, for
instance, going from a Camel Route to a Kamelet, this change is not
persisted until a property is changed.

This happens because the KaotoBridge is not subscribed to the
`code:updated` event and this is used when changing from one integration
type to another.

The fix is to subscribe to that envent. In addition to that, since [this
PR](KaotoIO#541), the
`VisibleFlowsProvider` was removed from the `Visualization` component,
hence it was breaking the VSCode integration. This PR also adds it to
the `KaotoBridge`

fixes: KaotoIO#402
@lordrip lordrip mentioned this issue Dec 12, 2023
Merged
@lordrip
Copy link
Member

lordrip commented Dec 12, 2023

when switching from Camel Route to Pipe editing and saving the initial route, the source file does not get updated to the latest state / still contains the Camel Route

This PR fixes this issue.

@lordrip lordrip moved this from In Progress to In Review in Kanban Board Dec 12, 2023
lordrip added a commit to lordrip/kaoto that referenced this issue Dec 15, 2023
@lordrip
fix(vscode): Fix VSCode switching integration type
e13a845 
Currently, when VSCode switch from one integration type to another, for
instance, going from a Camel Route to a Kamelet, this change is not
persisted until a property is changed.

This happens because the KaotoBridge is not subscribed to the
`code:updated` event and this is used when changing from one integration
type to another.

The fix is to subscribe to that envent. In addition to that, since [this
PR](KaotoIO#541), the
`VisibleFlowsProvider` was removed from the `Visualization` component,
hence it was breaking the VSCode integration. This PR also adds it to
the `KaotoBridge`

fixes: KaotoIO#402
lordrip added a commit that referenced this issue Dec 15, 2023
@lordrip
fix(vscode): Fix VSCode switching integration type
286baaa 
Currently, when VSCode switch from one integration type to another, for
instance, going from a Camel Route to a Kamelet, this change is not
persisted until a property is changed.

This happens because the KaotoBridge is not subscribed to the
`code:updated` event and this is used when changing from one integration
type to another.

The fix is to subscribe to that envent. In addition to that, since [this
PR](#541), the
`VisibleFlowsProvider` was removed from the `Visualization` component,
hence it was breaking the VSCode integration. This PR also adds it to
the `KaotoBridge`

fixes: #402
@github-project-automation github-project-automation bot moved this from In Review to Done in Kanban Board Dec 15, 2023
lordrip pushed a commit to lordrip/kaoto that referenced this issue Aug 30, 2024
@igarashitm
fix: Add isEmbedded=true to DataMapper.tsx
e22be51 
Fixes: KaotoIO#402
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lordrip lordrip

Labels
canvas/visualization Canvas-related issues enhancement New feature or request help wanted Extra attention is needed ui/ux This issue is about improving the UI / UX VS Code VS Code extension related issues
Projects
Kanban Board
Archived in project
Milestone
2.0.0 TP1
Development

Successfully merging a pull request may close this issue.

fix(vscode): Fix VSCode switching integration type lordrip/kaoto
2 participants
@lhein @lordrip