fix(303): persist visible flows when switching tabs #541
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
igarashitm
approved these changes
Dec 8, 2023
lordrip
added a commit
to lordrip/kaoto
that referenced
this pull request
Dec 12, 2023
Currently, when VSCode switch from one integration type to another, for instance, going from a Camel Route to a Kamelet, this change is not persisted until a property is changed. This happens because the KaotoBridge is not subscribed to the `code:updated` event and this is used when changing from one integration type to another. The fix is to subscribe to that envent. In addition to that, since [this PR](KaotoIO#541), the `VisibleFlowsProvider` was removed from the `Visualization` component, hence it was breaking the VSCode integration. This PR also adds it to the `KaotoBridge` fixes: KaotoIO#402
lordrip
added a commit
to lordrip/kaoto
that referenced
this pull request
Dec 15, 2023
Currently, when VSCode switch from one integration type to another, for instance, going from a Camel Route to a Kamelet, this change is not persisted until a property is changed. This happens because the KaotoBridge is not subscribed to the `code:updated` event and this is used when changing from one integration type to another. The fix is to subscribe to that envent. In addition to that, since [this PR](KaotoIO#541), the `VisibleFlowsProvider` was removed from the `Visualization` component, hence it was breaking the VSCode integration. This PR also adds it to the `KaotoBridge` fixes: KaotoIO#402
lordrip
added a commit
that referenced
this pull request
Dec 15, 2023
Currently, when VSCode switch from one integration type to another, for instance, going from a Camel Route to a Kamelet, this change is not persisted until a property is changed. This happens because the KaotoBridge is not subscribed to the `code:updated` event and this is used when changing from one integration type to another. The fix is to subscribe to that envent. In addition to that, since [this PR](#541), the `VisibleFlowsProvider` was removed from the `Visualization` component, hence it was breaking the VSCode integration. This PR also adds it to the `KaotoBridge` fixes: #402
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #303
vokoscreenNG-2023-12-08_16-08-46.mp4