Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support Camel Route onException #561

Closed
igarashitm opened this issue Dec 14, 2023 · 4 comments · Fixed by #819 or #827
Closed

Support Camel Route onException #561

igarashitm opened this issue Dec 14, 2023 · 4 comments · Fixed by #819 or #827
Assignees
@lordrip
Labels
canvas/config-form Configuration form related issues enhancement New feature or request
Milestone
2.0.0 TP2

Comments

@igarashitm
Copy link
Contributor

igarashitm commented Dec 14, 2023 •
edited
Loading

Please describe the feature that you want to propose

Splitted from #492

Support configuring onException element alone in Camel Route. Note that routeConfiguration also has onException as a property.

Since onException has steps inside, it needs flow visualization. Also see:
@igarashitm igarashitm added enhancement New feature or request canvas/config-form Configuration form related issues labels Dec 14, 2023
@igarashitm igarashitm mentioned this issue Dec 14, 2023
Closed
@igarashitm igarashitm moved this from New to Blocked in Kanban Board Dec 14, 2023
@igarashitm igarashitm mentioned this issue Dec 19, 2023
Open
@lhein lhein added this to the 2.0.0 TP2 milestone Jan 16, 2024
@lordrip lordrip moved this from Blocked to Todo in Kanban Board Feb 8, 2024
@lordrip
Copy link
Member

lordrip commented Feb 8, 2024 •
edited
Loading

Closing it in favor if #492

@lordrip lordrip closed this as completed Feb 8, 2024
@github-project-automation github-project-automation bot moved this from Todo to Done in Kanban Board Feb 8, 2024
@lordrip
Copy link
Member

lordrip commented Feb 8, 2024

My bad, this is a standalone issue, opening it again

@lordrip lordrip reopened this Feb 8, 2024
@github-project-automation github-project-automation bot moved this from Done to Todo in Kanban Board Feb 8, 2024
@lordrip lordrip self-assigned this Feb 8, 2024
@lordrip lordrip moved this from Todo to In Progress in Kanban Board Feb 8, 2024
@lordrip
Copy link
Member

lordrip commented Feb 8, 2024

Error handler docs: https://camel.apache.org/manual/error-handler.html

@lordrip
Copy link
Member

lordrip commented Feb 8, 2024

onException docs: https://camel.apache.org/manual/exception-clause.html

lordrip added a commit to lordrip/kaoto that referenced this issue Feb 8, 2024
@lordrip
feat(canvas): Support root OnException
f49c7c5 
This PR adds support for the root `OnException` entity. This entity have
a root configuration that is linked through the `CanvasForm` component
but also have a `steps` property, effectively turning it into a
`VisualEntity`.

The `getVizNodeFromProcessor` method was extracted from the
`AbstractCamelVisualEntity` class in order to reuse it in the
`OnExceptionVisualEntity` class. In an upcoming PR, more methods will be
extracted in order to avoid duplication as much as possible.

fix: KaotoIO#561
lordrip added a commit to lordrip/kaoto that referenced this issue Feb 8, 2024
@lordrip
feat(canvas): Support root OnException
ac97411 
This PR adds support for the root `OnException` entity. This entity has
a root configuration that is linked through the `CanvasForm` component
but also has a `steps` property, effectively turning it into a
`VisualEntity`.

The `getVizNodeFromProcessor` method was extracted from the
`AbstractCamelVisualEntity` class in order to reuse it in the
`OnExceptionVisualEntity` class. In an upcoming PR, more methods will be
extracted in order to avoid duplication as much as possible.

fix: KaotoIO#561
@lordrip lordrip mentioned this issue Feb 8, 2024
Merged
lordrip added a commit to lordrip/kaoto that referenced this issue Feb 8, 2024
@lordrip
feat(canvas): Support root OnException
a903d8c 
This PR adds support for the root `OnException` entity. This entity has
a root configuration that is linked through the `CanvasForm` component
but also has a `steps` property, effectively turning it into a
`VisualEntity`.

The `getVizNodeFromProcessor` method was extracted from the
`AbstractCamelVisualEntity` class in order to reuse it in the
`OnExceptionVisualEntity` class. In an upcoming PR, more methods will be
extracted in order to avoid duplication as much as possible.

There are more methods that could be extracted to avoid duplication, for instance:
1. `getNodeLabel()`
2. `getTooltipContent()`
3. `getComponentSchema()`
4. `updateModel()`

To make it possible, we would need to change how the `CamelRouteVisualEntity` is created,
as currently it requires a root `RouteDefinition` object, ideally, it should
receive a `{ route: RouteDefinition }` object instead.

fix: KaotoIO#561
@lordrip lordrip moved this from In Progress to In Review in Kanban Board Feb 8, 2024
lordrip added a commit that referenced this issue Feb 9, 2024
@lordrip
feat(canvas): Support root OnException
1d4541e 
This PR adds support for the root `OnException` entity. This entity has
a root configuration that is linked through the `CanvasForm` component
but also has a `steps` property, effectively turning it into a
`VisualEntity`.

The `getVizNodeFromProcessor` method was extracted from the
`AbstractCamelVisualEntity` class in order to reuse it in the
`OnExceptionVisualEntity` class. In an upcoming PR, more methods will be
extracted in order to avoid duplication as much as possible.

There are more methods that could be extracted to avoid duplication, for instance:
1. `getNodeLabel()`
2. `getTooltipContent()`
3. `getComponentSchema()`
4. `updateModel()`

To make it possible, we would need to change how the `CamelRouteVisualEntity` is created,
as currently it requires a root `RouteDefinition` object, ideally, it should
receive a `{ route: RouteDefinition }` object instead.

fix: #561
@github-project-automation github-project-automation bot moved this from In Review to Done in Kanban Board Feb 9, 2024
lordrip added a commit to lordrip/kaoto that referenced this issue Feb 12, 2024
@lordrip
feat(canvas): Add additional node's interactions
554bc1a 
Currently, all canvas' nodes have the possibility to be replaced and
removed.

This leads to an inconsistent situation in which empty containers
suggests that can be replaced or removed.

The fix for this situation is to offer the possibility to select whether
a node can be replaced or removed, this way, we have a broad range of
node interactions.

fix: KaotoIO#561
@lordrip lordrip mentioned this issue Feb 12, 2024
Merged
lordrip added a commit to lordrip/kaoto that referenced this issue Feb 12, 2024
@lordrip
feat(canvas): Add additional node's interactions
78df204 
Currently, all canvas' nodes have the possibility to be replaced and
removed.

This leads to an inconsistent situation in which empty containers
suggests that can be replaced or removed.

The fix for this situation is to offer the possibility to select whether
a node can be replaced or removed, this way, we have a broad range of
node interactions.

fix: KaotoIO#561
lordrip added a commit that referenced this issue Feb 12, 2024
@lordrip
feat(canvas): Add additional node's interactions
43a0c37 
Currently, all canvas' nodes have the possibility to be replaced and
removed.

This leads to an inconsistent situation in which empty containers
suggests that can be replaced or removed.

The fix for this situation is to offer the possibility to select whether
a node can be replaced or removed, this way, we have a broad range of
node interactions.

fix: #561
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lordrip lordrip

Labels
canvas/config-form Configuration form related issues enhancement New feature or request
Projects
Kanban Board
Archived in project
Milestone
2.0.0 TP2
3 participants
@igarashitm @lhein @lordrip