feat(canvas): Support root OnException #819
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR adds support for the root `OnException` entity. This entity has
a root configuration that is linked through the `CanvasForm` component
but also has a `steps` property, effectively turning it into a
`VisualEntity`.
The `getVizNodeFromProcessor` method was extracted from the
`AbstractCamelVisualEntity` class in order to reuse it in the
`OnExceptionVisualEntity` class. In an upcoming PR, more methods will be
extracted in order to avoid duplication as much as possible.
There are more methods that could be extracted to avoid duplication, for instance:
1. `getNodeLabel()`
2. `getTooltipContent()`
3. `getComponentSchema()`
4. `updateModel()`
To make it possible, we would need to change how the `CamelRouteVisualEntity` is created,
as currently it requires a root `RouteDefinition` object, ideally, it should
receive a `{ route: RouteDefinition }` object instead.
fix: KaotoIO#561
lordrip
force-pushed
the
feat/support-on-exception
branch
from
ac97411 to
a903d8c
Compare
igarashitm
approved these changes
Feb 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
This PR adds support for the root
OnExceptionentity. This entity has a root configuration that is linked through theCanvasFormcomponent but also has astepsproperty, effectively turning it into aVisualEntity.The
getVizNodeFromProcessormethod was extracted from theAbstractCamelVisualEntityclass in order to reuse it in theOnExceptionVisualEntityclass. In an upcoming PR, more methods will be extracted in order to avoid duplication as much as possible.Notes
There are more methods that could be extracted to avoid duplication, for instance:
getNodeLabel()getTooltipContent()getComponentSchema()updateModel()To make it possible, we would need to change how the
CamelRouteVisualEntityis created, as currently it requires a rootRouteDefinitionobject, ideally, it should receive a{ route: RouteDefinition }object instead.Screenshot
fix: #561