Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

increase the vertical spacing between the different parameter fields #618

Closed
lhein opened this issue Jan 11, 2024 · 1 comment · Fixed by #637
Closed

increase the vertical spacing between the different parameter fields #618

lhein opened this issue Jan 11, 2024 · 1 comment · Fixed by #637
Assignees
@lordrip
Labels
canvas/config-form Configuration form related issues ui/ux This issue is about improving the UI / UX
Milestone
2.0.0 TP1

Comments

@lhein
Copy link
Contributor

lhein commented Jan 11, 2024 •
edited
Loading

Image

In the image above you can see that the fields are really close to each other and its hard to visually separate where a field starts and ends. Could we somehow increase the vertical spacing between the fields of the different parameters or find other ways to make it more clear?
@lhein lhein converted this from a draft issue Jan 11, 2024
@lhein lhein added canvas/config-form Configuration form related issues ui/ux This issue is about improving the UI / UX labels Jan 11, 2024
@lhein lhein added this to the 2.0.0 milestone Jan 11, 2024
@lhein lhein moved this from New to Todo in Kanban Board Jan 11, 2024
lordrip added a commit to lordrip/kaoto that referenced this issue Jan 14, 2024
@lordrip
fix(form): Improve vertical spacing for form
69036c5 
Currently, there's no much spacing between form fields for processors.

This commit adds more spacing between them by enforcing the patternfly
form spacing.

fix: KaotoIO#618
@lordrip lordrip mentioned this issue Jan 14, 2024
Merged
lordrip added a commit to lordrip/kaoto that referenced this issue Jan 14, 2024
@lordrip
fix(form): Improve vertical spacing for form
b828903 
Currently, there's no much spacing between form fields for processors.

This commit adds more spacing between them by enforcing the patternfly
form spacing.

fix: KaotoIO#618
@lordrip lordrip modified the milestones: 2.0.0, 2.0.0 TP Jan 14, 2024
@lordrip lordrip moved this from Todo to In Review in Kanban Board Jan 14, 2024
@lordrip lordrip self-assigned this Jan 14, 2024
@lordrip
Copy link
Member

lordrip commented Jan 14, 2024

Yes, we can. I made #637, which brings the same fix that we did for v1. A final fix needs to be done on patternfly-uniforms side.

lordrip added a commit that referenced this issue Jan 15, 2024
@lordrip
fix(form): Improve vertical spacing for form
7357de1 
Currently, there's no much spacing between form fields for processors.

This commit adds more spacing between them by enforcing the patternfly
form spacing.

fix: #618
@github-project-automation github-project-automation bot moved this from In Review to Done in Kanban Board Jan 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lordrip lordrip

Labels
canvas/config-form Configuration form related issues ui/ux This issue is about improving the UI / UX
Projects
Kanban Board
Archived in project
Milestone
2.0.0 TP1
Development

Successfully merging a pull request may close this issue.

fix(form): Improve vertical spacing for form lordrip/kaoto
2 participants
@lhein @lordrip