fix(form): Improve vertical spacing for form #637
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, there's no much spacing between form fields for processors. This commit adds more spacing between them by enforcing the patternfly form spacing. fix: KaotoIO#618
lordrip
force-pushed
the
feat/improve-form-vertical-spacing
branch
from
69036c5 to
b828903
Compare
apupier
approved these changes
Jan 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Currently, there's not much spacing between form fields for processors.
Changes
This commit adds more spacing between them by enforcing the patternfly form spacing.
Notes
There's a different situation for the nested parameters (forms like
to: timer:myTimer) since they are not individual forms but rather a child of the main one, so the layout mechanism is different. This will be improved in an upcoming PR.fix: #618