KRKPD-1035: Kargo Adapter Strict Type Checking #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
klawil
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Bugfix
Feature
New bidder adapter
Updated bidder adapter
Code style update (formatting, local variables)
Refactoring (no functional changes, no api changes)
Build related changes
CI related changes
Does this change affect user-facing APIs or examples documented on http://prebid.org?
Other
Description of change
Type checking was added to the values that are both user and prebid provided following an issue where
validBidRequests[0].userId.tdidwas an object instead of a string which caused our backend to return a 400 error.We now check that the type of the input is of the type our API expects (or can be coerced to that type). If an invalid type is present, we report that information to the API in
root.ext.krg.verrfor alerting purposes. In some cases, we will alsologErrorthe correct format so publishers can see the issue.As part of increasing the type strictness, we also now validate the
placementIdparameter more closely inisBidRequestValidmaking sure that it is present, is a string, and starts with_(which all validplacementIds do).Other information
Kargo ticket - KRKPD-1035