Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KRKPD-1035: Kargo Adapter Strict Type Checking #35

Closed
wants to merge 4 commits into from
Closed

KRKPD-1035: Kargo Adapter Strict Type Checking #35

wants to merge 4 commits into from

Commits on May 9, 2024

  1. Update the buildRequests function to be more type strict 

    Still to do: getImpression
    @klawil
    klawil committed May 9, 2024
    Configuration menu
    Copy the full SHA
    46ccf18 View commit details
    Browse the repository at this point in the history

  2. Add strict type validation to getImpression and isBidRequestValid

    @klawil
    klawil committed May 9, 2024
    Configuration menu
    Copy the full SHA
    f260f2c View commit details
    Browse the repository at this point in the history

Commits on May 10, 2024

  1. Add console logs and transmit type validation errors

    @klawil
    klawil committed May 10, 2024
    Configuration menu
    Copy the full SHA
    4950619 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into KRKPD-1035-kargo-adapter-type-strict

    @klawil
    klawil committed May 10, 2024
    Configuration menu
    Copy the full SHA
    3441ada View commit details
    Browse the repository at this point in the history