improve the error message when a search fails #257
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sideangleside
suggested changes
Aug 7, 2018
bootstrap.py
Outdated
| @@ -699,7 +699,8 @@ def return_matching_key(api_path, search_key, return_key, null_result_ok=False): | |||
| elif result_len == 0 and null_result_ok is True: | |||
| return None | |||
| else: | |||
| print_error("%d element in array for search key '%s' in API '%s'. Please note that all searches are case-sensitive. Fatal error." % (result_len, search_key, api_path)) | |||
| print_error("%d element in array for search key '%s' in API '%s'. Please note that all searches are case-sensitive." % (result_len, search_key, api_path)) | |||
| print_error("Please also ensure the user can see the searched objects. Fatal error.") | |||
There was a problem hiding this comment.
I would change this to Please also ensure that the user has permissions to view the search objects
Otherwise, ack.
evgeni
force-pushed
the
better-fail-search
branch
from
917b4a0
to
60a1c81
Compare
sideangleside
approved these changes
Aug 7, 2018
evgeni
added a commit
to evgeni/katello-client-bootstrap
that referenced
this pull request
Jan 24, 2019
changelog: * Python 3 support * Capability to preserve proxy settings when reconfiguring/migrating the client (Katello#283) * EL5 subscription manager compatibility fixes (Katello#284) * Only yum clean metadata and dbcache, not RPMs (Katello#280) * Allow defining where to get ssh keys and where to store them (Katello#281) * Make the FIPS check more robust (Katello#279) * Support yum and dnf Python bindings (Katello#271) * Option to ignore registration failures (Katello#261) * Force lowercase FQDN writing puppet configuration (Katello#255) * Improve the error message when a search fails (Katello#257)
Merged
evgeni
added a commit
that referenced
this pull request
Jan 25, 2019
changelog: * Python 3 support * Capability to preserve proxy settings when reconfiguring/migrating the client (#283) * EL5 subscription manager compatibility fixes (#284) * Only yum clean metadata and dbcache, not RPMs (#280) * Allow defining where to get ssh keys and where to store them (#281) * Make the FIPS check more robust (#279) * Support yum and dnf Python bindings (#271) * Option to ignore registration failures (#261) * Force lowercase FQDN writing puppet configuration (#255) * Improve the error message when a search fails (#257)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.