default bootstrap.py to install katello-host-tools and omit the katello-agent package #258
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evgeni
requested changes
Aug 10, 2018
sideangleside
force-pushed
the
install-kt-tools-only
branch
from
688509e
to
de97036
Compare
evgeni
requested changes
Feb 14, 2019
bootstrap.py
Outdated
| if 'katello-agent' not in options.skip: | ||
| if 'katello-agent' in options.skip: | ||
| print_warning("Skipping the installation of the Katello Agent is now the default behavior. passing --skip katello-agent is deprecated") | ||
| if 'katello-agent' or 'katello-host-tools' not in options.skip: |
There was a problem hiding this comment.
this is always True, you want:
Suggested change
| if 'katello-agent' or 'katello-host-tools' not in options.skip: | |
| if 'katello-agent' not in options.skip or 'katello-host-tools' not in options.skip: |
evgeni
approved these changes
Feb 14, 2019
evgeni
added a commit
to evgeni/katello-client-bootstrap
that referenced
this pull request
Mar 8, 2019
* Bugfix for REX authorized_keys permission handling (Katello#298) * Improve error message and allow non-existing files for --rex-authpath (Katello#299) * Improve --rex-urlkeyfile help text (Katello#293) * Default bootstrap.py to install katello-host-tools and omit the katello-agent package (Katello#258) * Improve output when using the rex options (Katello#291) * Don't fail if yum clean fails (Katello#289) * Don't use json.loads to generate dicts (Katello#288) * Bugfix: don't build a newly created host (Katello#287) * Call rhn-migrate-classic-to-rhsm with --remove-rhn-packages (Katello#137) * Allow fetching REX keys from the API (Katello#282)
Merged
evgeni
added a commit
that referenced
this pull request
Mar 12, 2019
* Bugfix for REX authorized_keys permission handling (#298) * Improve error message and allow non-existing files for --rex-authpath (#299) * Improve --rex-urlkeyfile help text (#293) * Default bootstrap.py to install katello-host-tools and omit the katello-agent package (#258) * Improve output when using the rex options (#291) * Don't fail if yum clean fails (#289) * Don't use json.loads to generate dicts (#288) * Bugfix: don't build a newly created host (#287) * Call rhn-migrate-classic-to-rhsm with --remove-rhn-packages (#137) * Allow fetching REX keys from the API (#282)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #251