Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix rex-urlkeyfile help text (#292) #293

Merged
merged 2 commits into from
Feb 19, 2019
Merged

Conversation

swadeley
Copy link
Contributor

Improve help text for --rex-urlkeyfile command #292

Improve help text for --rex-urlkeyfile command Katello#292
@sideangleside
Copy link
Member

Thanks for the PR @swadeley. LGTM 👍

@sideangleside sideangleside self-requested a review February 14, 2019 12:05
Copy link
Member

@evgeni evgeni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this also needs to be updated in bootstrap.py

update help to match readme.
@swadeley
Copy link
Contributor Author

Hello, sorry for delay. Let me know if I need to squash the commits.

@evgeni evgeni merged commit f7ad0f1 into Katello:master Feb 19, 2019
@evgeni
Copy link
Member

evgeni commented Feb 19, 2019

thanks @swadeley, and no github can squash for us :)

@swadeley
Copy link
Contributor Author

Thank you @evgeni

@swadeley swadeley deleted the issue#292 branch February 19, 2019 11:59
evgeni added a commit to evgeni/katello-client-bootstrap that referenced this pull request Mar 8, 2019
* Bugfix for REX authorized_keys permission handling (Katello#298)
* Improve error message and allow non-existing files for --rex-authpath (Katello#299)
* Improve --rex-urlkeyfile help text (Katello#293)
* Default bootstrap.py to install katello-host-tools and omit the katello-agent package (Katello#258)
* Improve output when using the rex options (Katello#291)
* Don't fail if yum clean fails (Katello#289)
* Don't use json.loads to generate dicts (Katello#288)
* Bugfix: don't build a newly created host (Katello#287)
* Call rhn-migrate-classic-to-rhsm with --remove-rhn-packages (Katello#137)
* Allow fetching REX keys from the API (Katello#282)
@evgeni evgeni mentioned this pull request Mar 8, 2019
evgeni added a commit that referenced this pull request Mar 12, 2019
* Bugfix for REX authorized_keys permission handling (#298)
* Improve error message and allow non-existing files for --rex-authpath (#299)
* Improve --rex-urlkeyfile help text (#293)
* Default bootstrap.py to install katello-host-tools and omit the katello-agent package (#258)
* Improve output when using the rex options (#291)
* Don't fail if yum clean fails (#289)
* Don't use json.loads to generate dicts (#288)
* Bugfix: don't build a newly created host (#287)
* Call rhn-migrate-classic-to-rhsm with --remove-rhn-packages (#137)
* Allow fetching REX keys from the API (#282)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants