This repository has been archived by the owner on Nov 24, 2021. It is now read-only.
fixes #15063 - set answers for foreman client certs #335
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
puppet-foreman now exposes the foreman client certificates through parameters. Since Katello wants to change these from puppet to custom handling, these must be set. puppet-certs currently attempts to do so through foreman-rake config. Since puppet-foreman has started to set these in settings.yaml, they can't be overridden anymore. By setting these in the answers file, we avoid that conflict.
|
Needs theforeman/puppet-certs#88, too |
|
can |
|
Not sure, @thomasmckay would know. If it can, I'd say it should be removed in a different issue though, one that specifically tracks sam removal. |
ACK |
|
Awesome! Thanks @ekohl! |
zjhuntin
pushed a commit
to zjhuntin/katello-installer
that referenced
this pull request
Oct 30, 2018
Refs #12673 - Filter Rules now show date type
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
puppet-foreman now exposes the foreman client certificates through
parameters. Since Katello wants to change these from puppet to custom
handling, these must be set. puppet-certs currently attempts to do so
through foreman-rake config. Since puppet-foreman has started to set
these in settings.yaml, they can't be overridden anymore. By setting
these in the answers file, we avoid that conflict.