Skip to content
This repository has been archived by the owner on Nov 24, 2021. It is now read-only.

fixes #15063 - Set answers for foreman client certs #334

Closed
wants to merge 1 commit into from

Conversation

ekohl
Copy link
Member

@ekohl ekohl commented May 16, 2016

theforeman/puppet-foreman@ec8c6c2 exposes the foreman client certificates through parameters. Since Katello wants to change these from puppet to custom handling, these must be set. puppet-certs currently attempts to do so through foreman-rake config. Since puppet-foreman has started to set these in settings.yaml, they can't be overridden anymore. By setting these in the answers file, we avoid that conflict.

Note I didn't test this yet, but I believe this will become a problem so I opened this to track it.

theforeman/puppet-foreman@ec8c6c2
exposes the foreman client certificates through parameters. Since
Katello wants to change these from puppet to custom handling, these must
be set. puppet-certs currently attempts to do so through
foreman-rake config. Since puppet-foreman has started to set these in
settings.yaml, they can't be overridden anymore. By setting these in the
answers file, we avoid that conflict.
@theforeman-bot
Copy link

There were the following issues with the commit message:

  • 1608c1e must be in the format fixes #redmine_number - brief description
  • commit message for 1608c1e is not wrapped at 72nd column

If you don't have a ticket number, please create an issue in Redmine, selecting the appropriate project.

More guidelines are available in Coding Standards or on the Foreman wiki.


This message was auto-generated by Foreman's prprocessor

@stbenjam
Copy link
Contributor

This replaces theforeman/puppet-certs#87, right?

@stbenjam
Copy link
Contributor

Need to get this in ASAP, as it seems to have broken our nightly install:

 /Stage[main]/Certs::Foreman/Exec[foreman_certs_config]/returns: change from notrun to 0 failed: /usr/share/foreman/script/foreman-rake config --      -k ssl_ca_file -v '/etc/foreman/proxy_ca.pem'      -k ssl_certificate -v '/etc/foreman/client_cert.pem'      -k ssl_priv_key -v '/etc/foreman/client_key.pem' returned 1 instead of one of [0]

@stbenjam stbenjam changed the title Set answers for foreman client certs fixes #15063 - Set answers for foreman client certs May 16, 2016
@stbenjam
Copy link
Contributor

I think the paths should be:

  $foreman_client_cert    = '/etc/foreman/client_cert.pem'
  $foreman_client_key     = '/etc/foreman/client_key.pem'
  $foreman_ssl_ca_cert    = '/etc/foreman/proxy_ca.pem'

@stbenjam
Copy link
Contributor

stbenjam commented May 16, 2016

With these paths above, and removing the stanzas from puppet-certs (the ones theforeman/puppet-certs#87 tried to change) entirely, I get a clean install.

@stbenjam
Copy link
Contributor

Closed in favor of #335

@stbenjam stbenjam closed this May 16, 2016
@ekohl ekohl deleted the foreman-client-certs branch May 16, 2016 17:46
zjhuntin pushed a commit to zjhuntin/katello-installer that referenced this pull request Oct 30, 2018
Fixes #12756: update hammer host collections to use hosts.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants