Use foreman_config_entry instead of manual rake config #87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
theforeman/puppet-foreman#442 is an alternative approach. Using that would mean simply setting the correct answers. |
|
I can test this out with our module-pr tester in kdeploy. As for the parameters, I'd still probably learn towards this approach given we'd have to define the certs in the answers file of the installer and then they are hard-coded as opposed to this approach that will update them if anything changes. |
|
The current certificate locations are already hardcoded in the katello-installer answers file. By implementing this, you reduce coupling which I think is a good thing. |
|
Closed in favor of #88 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I should note that I haven't tested this yet, this is mostly to check if this is even a good idea. theforeman/puppet-foreman#441 also suggested that this should be part of puppet-foreman itself.