Fixes #20307 - Add unicode char check to certs check #521
Conversation
|
Issues: #20307 |
|
Example of output: Checking for non unicode characters[FAIL] /etc/pki/ca-trust/extracted/pem/tls-ca-bundle.pem:1426:# Certinomis - Autorité Racine /etc/pki/ca-trust/extracted/pem/tls-ca-bundle.pem:3058:# NetLock Arany (Class Gold) Főtanúsítvány /etc/pki/ca-trust/extracted/pem/tls-ca-bundle.pem:4223:# TÜRKTRUST Elektronik Sertifika Hizmet Sağlayıcısı /etc/pki/ca-trust/extracted/pem/tls-ca-bundle.pem:4395:# TÜBİTAK UEKAE Kök Sertifika Hizmet Sağlayıcısı - Sürüm 3 /etc/pki/ca-trust/extracted/pem/tls-ca-bundle.pem:4427:# TÜRKTRUST Elektronik Sertifika Hizmet Sağlayıcısı H5 /etc/pki/ca-trust/extracted/pem/tls-ca-bundle.pem:4454:# TÜRKTRUST Elektronik Sertifika Hizmet Sağlayıcısı H6 |
|
@ekohl can I get a review please 🍻 build failure is unrelated. |
|
theforeman/puppet-katello#198 and theforeman/puppet-foreman_proxy_content#129 should fix the build issue. |
bin/katello-certs-check
Outdated
| @@ -112,11 +112,24 @@ function check-ca-bundle () { | |||
| fi | |||
| } | |||
|
|
|||
| function check-non-unicode () { | |||
There was a problem hiding this comment.
Do you mean non-ascii instead of non-unicode?
|
[test] |
|
@ekohl can I get another review please, also if it looks good can you kick off the travis job again I dont have the ability to. |
|
I'm not sure why it's still not able to do a build, but that's not related to this PR. |
|
@ekohl cool thanks for the review 🍺 since its not related did you want want for it to get fixed before merge? |
|
@ekohl since the tests are not related did you want to merge or hold off and wait? |
|
I was hoping for a second ACK but I don't mind merging. |
(cherry picked from commit 4cdf033)
(cherry picked from commit 4cdf033)
Fixed a few grammer mistakes as well on some of the other functions.