Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow pulp 5.x #198

Merged
merged 1 commit into from
Jul 20, 2017
Merged

Allow pulp 5.x #198

merged 1 commit into from
Jul 20, 2017

Conversation

ekohl
Copy link
Member

@ekohl ekohl commented Jul 18, 2017

No description provided.

@ekohl ekohl mentioned this pull request Jul 18, 2017
Merged
chris1984
chris1984 reviewed Jul 20, 2017
View reviewed changes
Copy link
Member

@chris1984 chris1984 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ekohl is there any harm with bringing in Pulp 5.x

@ekohl
Copy link
Member Author

ekohl commented Jul 20, 2017

Currently I don't think there is. Everything should be compatible but it dropped Puppet 3. Since Katello did the same that shouldn't be an issue.

chris1984
chris1984 approved these changes Jul 20, 2017
View reviewed changes
Copy link
Member

@chris1984 chris1984 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ekohl cool thanks, approving then based on the last comment.

@ekohl ekohl merged commit b2198f1 into theforeman:master Jul 20, 2017
@ekohl ekohl deleted the allow-newer-pulp branch July 20, 2017 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chris1984 chris1984 chris1984 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ekohl @chris1984