feat(evmutil): add proto for MsgConvertNativeCoinToERC20 #1595
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pirtleshell
requested review from
DracoLi,
nddeluca,
rhuairahrighairidh,
galxy25 and
drklee3
galxy25
reviewed
May 22, 2023
| _ legacytx.LegacyMsg = &MsgConvertERC20ToCoin{} | ||
|
|
||
| _ sdk.Msg = &MsgConvertNativeCoinToERC20{} |
There was a problem hiding this comment.
prefer Cosmos vs Native as conceptually Kava is a co-chain that "natively" supports evm and cosmos blockchains but in the future might also allow for converting things like BTC more directly
There was a problem hiding this comment.
i support the name change. it's a big enough change set to move references from "Native Coin" to "Cosmos Coin" that i want to make it in a follow up pr that changes all the unreleased types (like the allowed_native_denoms param), not just the one for this message.
galxy25
reviewed
May 22, 2023
galxy25
approved these changes
May 22, 2023
pirtleshell
force-pushed
the
rp-evmutil-convert-native-coin-proto
branch
from
116e7e9 to
8facfae
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds the proto with Msg implementations and validations for ConvertNativeCoinToERC20 message. The message is registered in evmutil's message server to allow the binary to build, but the implementation will be added in a following PR. Changelog & doc updates will be made with the implementation.
Hoping to keep the PRs as bite-sized as possible in hopes of efficient and effective reviews.
Checklist
Changelog has been updated as necessary.