update new names, NativeCoin -> CosmosCoin #1596
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pirtleshell
commented
May 23, 2023
Comment on lines
+21
to
+24
| # TODO: reenable me after merge of Native -> Cosmos name change committed to master. | ||
| # - run: make check-proto-breaking-remote | ||
| # - run: BUF_CHECK_BREAKING_AGAINST_REMOTE="branch=$GITHUB_BASE_REF" make check-proto-breaking-remote | ||
| # if: github.event_name == 'pull_request' |
There was a problem hiding this comment.
i am disabling these checks temporarily. i've confirmed all breaking proto changes are only for unreleased types:
Checking for proto backward compatibility
proto/kava/evmutil/v1beta1/conversion_pair.proto:1:1:Previously present message "AllowedNativeCoinERC20Token" was deleted from file.
proto/kava/evmutil/v1beta1/genesis.proto:50:3:Field "1" with name "allowed_cosmos_denoms" on message "Params" changed option "json_name" from "allowedNativeDenoms" to "allowedCosmosDenoms".
proto/kava/evmutil/v1beta1/genesis.proto:50:12:Field "1" on message "Params" changed type from "kava.evmutil.v1beta1.AllowedNativeCoinERC20Token" to "kava.evmutil.v1beta1.AllowedCosmosCoinERC20Token".
proto/kava/evmutil/v1beta1/genesis.proto:50:40:Field "1" on message "Params" changed name from "allowed_native_denoms" to "allowed_cosmos_denoms".
proto/kava/evmutil/v1beta1/tx.proto:1:1:Previously present message "MsgConvertNativeCoinToERC20" was deleted from file.
proto/kava/evmutil/v1beta1/tx.proto:1:1:Previously present message "MsgConvertNativeCoinToERC20Response" was deleted from file.
proto/kava/evmutil/v1beta1/tx.proto:13:1:Previously present RPC "ConvertNativeCoinToERC20" on service "Msg" was deleted.
intend to reenable in next pr.
1 task
galxy25
approved these changes
May 23, 2023
|
approved pending fix of |
DracoLi
approved these changes
May 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updates newly added types with a better name. What were objects referring to "native" coins & denoms now refer to "cosmos" coins and denoms.
Checklist