Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stylecheck #1640

Closed
wants to merge 23 commits into from
Closed

Stylecheck #1640

wants to merge 23 commits into from

Conversation

faddat
Copy link
Contributor

@faddat faddat commented Jun 22, 2023

This PR enables the stylecheck linter

  • .github
  • golangci-lint run ./... --fix
  • disable linters with issues and run gci
  • configure gci
  • sort imports correctly
  • enable the unconvert linter and fix unnecessary conversions
  • eliminate unnecessary conversions
  • add ineffassign and address ineffectual assignments
  • begin applying stylecheck

@faddat faddat marked this pull request as ready for review June 24, 2023 15:06
@karzak karzak closed this Jan 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants