add packet forward middleware #1643
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #1633
Hi, so the other day Josh Lee asked if Kava had
packet forward middleware.
I thought that was a great idea, so looked into
adding it.
This PR contains all of the linting PR's that I've
made recently, they can be reviewed sequentially for
ease.
It may also make sense to write some tests for pfm,
and after merging the linting PRs, do some tests
with PFM, it can get a little picky
implementation-wise.
Happy to assist with those, too.
-Jacob
Note: this PR currently looks like it changes 486 files, but if:
are all merged, this PR should touch only app.go and the protonet genesis, which may require additional updates (I just put the relevant genesis state in it but if it corresponds to a live network, that may not be the right approach)