Revert "CI test: Make sure FsharpSuite test failure stops and fails w…

…hole CI job (dotnet#14743)" This reverts commit 979fa51.
KevinRansom · Feb 20, 2023 · 794203f · 794203f
1 parent 03a02fe
commit 794203f
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 11 deletions.
diff --git a/eng/Build.ps1 b/eng/Build.ps1
@@ -311,15 +311,13 @@ function TestUsingMSBuild([string] $testProject, [string] $targetFramework, [str
     if ($env:RunningAsPullRequest -ne "true" -and $noTestFilter -eq $false) {
         $args += " --filter TestCategory!=PullRequest"
     }
+
 
     if ($asBackgroundJob) {
         Write-Host("Starting on the background: $args")
         Write-Host("------------------------------------")
         $bgJob = Start-Job -ScriptBlock {       
             & $using:dotnetExe test $using:testProject -c $using:configuration -f $using:targetFramework -v n --test-adapter-path $using:testadapterpath --logger "nunit;LogFilePath=$using:testLogPath" /bl:$using:testBinLogPath  --blame --results-directory $using:ArtifactsDir\TestResults\$using:configuration
-            if ($LASTEXITCODE -ne 0) { 
-                throw "Command failed to execute with exit code $($LASTEXITCODE): $using:dotnetExe $using:args" 
-            }           
         }
         return $bgJob
     } else{
@@ -544,7 +542,7 @@ try {
 
         # Collect output from  background jobs
         Wait-job $bgJob | out-null
-        Receive-Job $bgJob -ErrorAction Stop
+        Receive-Job $bgJob 
     }
 
     if ($testCoreClr) {
@@ -559,7 +557,7 @@ try {
 
         # Collect output from  background jobs
         Wait-job $bgJob | out-null
-        Receive-Job $bgJob -ErrorAction Stop  
+        Receive-Job $bgJob    
     }
 
     if ($testFSharpQA) {

diff --git a/tests/fsharp/tests.fs b/tests/fsharp/tests.fs
@@ -91,30 +91,25 @@ module CoreTests =
         singleVersionedNegTest cfg "preview" "test-langversion-preview"
 
     [<Test>]
-    [<Ignore("Failing CI since 17.6, will be resolved separately", Until = "2023-04-01")>]
     let ``auto-widen-version-5_0``() = 
         let cfg = testConfig "core/auto-widen/5.0"
         singleVersionedNegTest cfg "5.0" "test"
 
     [<Test>]
-    [<Ignore("Failing CI since 17.6, will be resolved separately", Until = "2023-04-01")>]
     let ``auto-widen-version-FSC_DEBUG-preview``() =
         singleTestBuildAndRunVersion "core/auto-widen/preview" FSC_DEBUG "preview"
 
     [<Test>]
-    [<Ignore("Failing CI since 17.6, will be resolved separately", Until = "2023-04-01")>]
     let ``auto-widen-version-FSC_OPTIMIZED-preview``() =
         singleTestBuildAndRunVersion "core/auto-widen/preview" FSC_OPTIMIZED "preview"
 
     [<Test>]
-    [<Ignore("Failing CI since 17.6, will be resolved separately", Until = "2023-04-01")>]
     let ``auto-widen-version-preview-warns-on``() = 
         let cfg = testConfig "core/auto-widen/preview"
         let cfg = { cfg with fsc_flags = cfg.fsc_flags + " --warnon:3388 --warnon:3389 --warnon:3395 --warnaserror+ --define:NEGATIVE" }
         singleVersionedNegTest cfg "preview" "test"
 
     [<Test>]
-    [<Ignore("Failing CI since 17.6, will be resolved separately", Until = "2023-04-01")>]
     let ``auto-widen-version-preview-default-warns``() = 
         let cfg = testConfig "core/auto-widen/preview-default-warns"
         let cfg = { cfg with fsc_flags = cfg.fsc_flags + " --warnaserror+ --define:NEGATIVE" }
@@ -2807,7 +2802,6 @@ module TypecheckTests =
     let ``type check neg20`` () = singleNegTest (testConfig "typecheck/sigs") "neg20"
 
     [<Test>]
-    [<Ignore("Failing CI since 17.6, will be resolved separately", Until = "2023-04-01")>]
     let ``type check neg20 version 5_0`` () =
         let cfg = testConfig "typecheck/sigs/version50"
         singleVersionedNegTest cfg "5.0" "neg20"