CI test: Make sure FsharpSuite test failure stops and fails whole CI job #14743
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Do not update, do not merge. |
|
/azp run |
|
Pull request contains merge conflicts. |
|
Now it fails as it should:
Next step, I am going to re-ignore the failing test, so that CI is green and this can get merged. |
T-Gro
commented
Feb 14, 2023
This is the suite of tests which I am migrating to componenttests with another (in process) mode of execution. Will make sure those are run there.
abonie
approved these changes
Feb 15, 2023
KevinRansom
approved these changes
Feb 16, 2023
KevinRansom
added a commit
to KevinRansom/fsharp
that referenced
this pull request
Feb 20, 2023
…hole CI job (dotnet#14743)" This reverts commit 979fa51.
KevinRansom
added a commit
to KevinRansom/fsharp
that referenced
this pull request
Feb 20, 2023
…hole CI job (dotnet#14743)" This reverts commit 979fa51.
kant2002
pushed a commit
to kant2002/fsharp
that referenced
this pull request
Apr 1, 2023
…job (dotnet#14743) * If background test run fails, stop entire run * Background job for running tests passed "Exit" on * TESTONLY:Let this test fail * Make test ignored again * Ignore tests in this PR (to enable FshapSuite failiure) This is the suite of tests which I am migrating to componenttests with another (in process) mode of execution. Will make sure those are run there.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.