Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI test: Make sure FsharpSuite test failure stops and fails whole CI job #14743

Merged
merged 10 commits into from
Feb 16, 2023
Merged

CI test: Make sure FsharpSuite test failure stops and fails whole CI job #14743

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
232c159
If background test run fails, stop entire run
T-Gro Feb 13, 2023
a68c748
Merge branch 'main' into fsharpsuite-fial-CI-if-fails
T-Gro Feb 13, 2023
3731d39
Background job for running tests passed "Exit" on
T-Gro Feb 13, 2023
ca68d48
Merge branch 'main' into fsharpsuite-fial-CI-if-fails
T-Gro Feb 13, 2023
758379d
TESTONLY:Let this test fail
T-Gro Feb 13, 2023
697e278
Make test ignored again
T-Gro Feb 14, 2023
ddfd280
Merge branch 'main' into fsharpsuite-fial-CI-if-fails
T-Gro Feb 14, 2023
d1e4107
Merge remote-tracking branch 'upstream/main' into fsharpsuite-fial-CI…
T-Gro Feb 14, 2023
31a59bb
Ignore tests in this PR (to enable FshapSuite failiure)
T-Gro Feb 15, 2023
9840f17
Merge remote-tracking branch 'upstream/main' into fsharpsuite-fial-CI…
T-Gro Feb 15, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions eng/Build.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -311,13 +311,15 @@ function TestUsingMSBuild([string] $testProject, [string] $targetFramework, [str
if ($env:RunningAsPullRequest -ne "true" -and $noTestFilter -eq $false) {
$args += " --filter TestCategory!=PullRequest"
}


if ($asBackgroundJob) {
Write-Host("Starting on the background: $args")
Write-Host("------------------------------------")
$bgJob = Start-Job -ScriptBlock {
& $using:dotnetExe test $using:testProject -c $using:configuration -f $using:targetFramework -v n --test-adapter-path $using:testadapterpath --logger "nunit;LogFilePath=$using:testLogPath" /bl:$using:testBinLogPath --blame --results-directory $using:ArtifactsDir\TestResults\$using:configuration
if ($LASTEXITCODE -ne 0) {
throw "Command failed to execute with exit code $($LASTEXITCODE): $using:dotnetExe $using:args"
}
}
return $bgJob
} else{
Expand Down Expand Up @@ -542,7 +544,7 @@ try {

# Collect output from background jobs
Wait-job $bgJob | out-null
Receive-Job $bgJob
Receive-Job $bgJob -ErrorAction Stop
}

if ($testCoreClr) {
Expand All @@ -557,7 +559,7 @@ try {

# Collect output from background jobs
Wait-job $bgJob | out-null
Receive-Job $bgJob
Receive-Job $bgJob -ErrorAction Stop
}

if ($testFSharpQA) {
Expand Down
6 changes: 6 additions & 0 deletions tests/fsharp/tests.fs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,25 +91,30 @@ module CoreTests =
singleVersionedNegTest cfg "preview" "test-langversion-preview"

[<Test>]
[<Ignore("Failing CI since 17.6, will be resolved separately", Until = "2023-04-01")>]
let ``auto-widen-version-5_0``() =
let cfg = testConfig "core/auto-widen/5.0"
singleVersionedNegTest cfg "5.0" "test"

[<Test>]
[<Ignore("Failing CI since 17.6, will be resolved separately", Until = "2023-04-01")>]
let ``auto-widen-version-FSC_DEBUG-preview``() =
singleTestBuildAndRunVersion "core/auto-widen/preview" FSC_DEBUG "preview"

[<Test>]
[<Ignore("Failing CI since 17.6, will be resolved separately", Until = "2023-04-01")>]
let ``auto-widen-version-FSC_OPTIMIZED-preview``() =
singleTestBuildAndRunVersion "core/auto-widen/preview" FSC_OPTIMIZED "preview"

[<Test>]
[<Ignore("Failing CI since 17.6, will be resolved separately", Until = "2023-04-01")>]
let ``auto-widen-version-preview-warns-on``() =
let cfg = testConfig "core/auto-widen/preview"
let cfg = { cfg with fsc_flags = cfg.fsc_flags + " --warnon:3388 --warnon:3389 --warnon:3395 --warnaserror+ --define:NEGATIVE" }
singleVersionedNegTest cfg "preview" "test"

[<Test>]
[<Ignore("Failing CI since 17.6, will be resolved separately", Until = "2023-04-01")>]
let ``auto-widen-version-preview-default-warns``() =
let cfg = testConfig "core/auto-widen/preview-default-warns"
let cfg = { cfg with fsc_flags = cfg.fsc_flags + " --warnaserror+ --define:NEGATIVE" }
Expand Down Expand Up @@ -2802,6 +2807,7 @@ module TypecheckTests =
let ``type check neg20`` () = singleNegTest (testConfig "typecheck/sigs") "neg20"

[<Test>]
[<Ignore("Failing CI since 17.6, will be resolved separately", Until = "2023-04-01")>]
let ``type check neg20 version 5_0`` () =
let cfg = testConfig "typecheck/sigs/version50"
singleVersionedNegTest cfg "5.0" "neg20"
Expand Down