Auto-update generated files if UPDATE_SNAPSHOTS=1 is set
#212
Labels
good first issue
Good for newcomers
help wanted
Issues that anyone could pick up and implement if useful to them
internal
Comments
benjaminjkraft
added
good first issue
6 tasks
6 tasks
benjaminjkraft
added a commit
that referenced
this issue
Dec 22, 2022
If you do `UPDATE_SNAPSHOTS=1 go test ./...` that will: 1. run the snapshot tests, updating any changed snapshots 2. run the integration tests and (if you have tokens) example tests 3. check that the code for the integration tests and example tests is up-to-date Step 3 is not strictly a snapshot test; the generated code is actually checked in and used. But, I mean, it's basically the same! So now, we also update it if you asked to update snapshots, which is hopefully a little more convenient. Fixes #212. Test plan: Make a trivial change to `example/generated.go`; `go test ./...` should now fail. `UPDATE_SNAPSHOTS=1 go test ./...` should also fail, but say it updated the snapshot, and the change should be reverted. Run `go test ./...` again; it should pass again.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
If you do
UPDATE_SNAPSHOTS=1 go test ./...that will:Step 3 is not strictly a snapshot test; the generated code is actually checked in and used. But, I mean, it's basically the same! So we should probably update it in the same places; if you need to update the snapshots you also probably need to update the integration tests. It's a little weirder because you'll also now need to re-run them (since they test things other than the snapshots) but that's probably ok.
The text was updated successfully, but these errors were encountered: