Automatically update generated files if UPDATE_SNAPSHOTS=1 #243
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If you do `UPDATE_SNAPSHOTS=1 go test ./...` that will: 1. run the snapshot tests, updating any changed snapshots 2. run the integration tests and (if you have tokens) example tests 3. check that the code for the integration tests and example tests is up-to-date Step 3 is not strictly a snapshot test; the generated code is actually checked in and used. But, I mean, it's basically the same! So now, we also update it if you asked to update snapshots, which is hopefully a little more convenient. Test plan: Make a trivial change to `example/generated.go`; `go test ./...` should now fail. `UPDATE_SNAPSHOTS=1 go test ./...` should also fail, but say it updated the snapshot, and the change should be reverted. Run `go test ./...` again; it should pass again.
benjaminjkraft
requested review from
csilvers,
dnerdy and
StevenACoffman
as code owners
StevenACoffman
approved these changes
Dec 19, 2022
There was a problem hiding this comment.
Yay! @kevinbarabash This is the behavior I think you were looking for in webapp, right?
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you do
UPDATE_SNAPSHOTS=1 go test ./...that will:Step 3 is not strictly a snapshot test; the generated code is actually checked in and used. But, I mean, it's basically the same! So now, we also update it if you asked to update snapshots, which is hopefully a little more convenient.
Fixes #212.
Test plan:
Make a trivial change to
example/generated.go;go test ./...should now fail.UPDATE_SNAPSHOTS=1 go test ./...should also fail, but say it updated the snapshot, and the change should be reverted. Rungo test ./...again; it should pass again.I have: