Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Go 1.20 to tests #256

Closed
benjaminjkraft opened this issue Feb 15, 2023 · 0 comments · Fixed by #262
Closed

Add Go 1.20 to tests #256

benjaminjkraft opened this issue Feb 15, 2023 · 0 comments · Fixed by #262
Labels
good first issue Good for newcomers help wanted Issues that anyone could pick up and implement if useful to them internal

Comments

@benjaminjkraft
Copy link
Collaborator

Go 1.20 is out, so we may as well test against it! See #219 for the last upgrade.
@benjaminjkraft benjaminjkraft added good first issue Good for newcomers help wanted Issues that anyone could pick up and implement if useful to them internal labels Feb 15, 2023
@benjaminjkraft benjaminjkraft mentioned this issue Apr 8, 2023
Merged
6 tasks
benjaminjkraft added a commit that referenced this issue Apr 8, 2023
@benjaminjkraft
Bump minimum Go version to 1.18 (#262)
677fa94 
This means we can use generics and various other things. I didn't use
any of them yet, this is just bumping the numbers. I added tests for
1.20, and fixed one small bug, I think caused by `go/packages` changes
therein. And I bumped the golangci-lint version too while I was in the
area.

Fixes #256, fixes #257.

I have:
- [x] Written a clear PR title and description (above)
- [x] Signed the [Khan Academy CLA](https://www.khanacademy.org/r/cla)
- [x] Added tests covering my changes, if applicable
- [x] Included a link to the issue fixed, if applicable
- [x] Included documentation, for new features
- [x] Added an entry to the changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers help wanted Issues that anyone could pick up and implement if useful to them internal
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Bump minimum Go version to 1.18 Khan/genqlient
1 participant
@benjaminjkraft