Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop Go <1.18 #257

Closed
benjaminjkraft opened this issue Feb 15, 2023 · 3 comments · Fixed by #262
Closed

Drop Go <1.18 #257

benjaminjkraft opened this issue Feb 15, 2023 · 3 comments · Fixed by #262
Labels
internal

Comments

@benjaminjkraft
Copy link
Collaborator

This is useful because we can use generics. For example, #252 is gonna be a bit tricky to integration test in part because it would require build tagging a bunch of things. And we can also use generics internally which will probably have at least a little value.

None of this is urgent if people are still using older Go though. @csilvers or @dnerdy, have y'all upgraded to 1.18 yet? Any other users who are still on 1.17 or below?
@benjaminjkraft
Copy link
Collaborator Author

Another reason to get to 1.18 is so we can put our version in easily (i.e. finally do the thing that #127/#129 wanted to) via runtime.DebugInfo.

@StevenACoffman
Copy link
Member

@benjaminjkraft We are in the process of upgrading to Go 1.19 from Go 1.16, but that has not been completed yet.

@csilvers
Copy link
Member

@benjaminjkraft We are in the process of upgrading to Go 1.19 from Go 1.16, but that has not been completed yet.

(I expect it will be completed in 1-2 weeks.)

That said, we have no plans to upgrade our genqlient before our go1.19 upgrade is complete, so I don't think landing this PR needs to block on us!

This was referenced Apr 8, 2023
Merged
Merged
benjaminjkraft added a commit that referenced this issue Apr 8, 2023
@benjaminjkraft
Bump minimum Go version to 1.18 (#262)
677fa94 
This means we can use generics and various other things. I didn't use
any of them yet, this is just bumping the numbers. I added tests for
1.20, and fixed one small bug, I think caused by `go/packages` changes
therein. And I bumped the golangci-lint version too while I was in the
area.

Fixes #256, fixes #257.

I have:
- [x] Written a clear PR title and description (above)
- [x] Signed the [Khan Academy CLA](https://www.khanacademy.org/r/cla)
- [x] Added tests covering my changes, if applicable
- [x] Included a link to the issue fixed, if applicable
- [x] Included documentation, for new features
- [x] Added an entry to the changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
internal
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Bump minimum Go version to 1.18 Khan/genqlient
3 participants
@benjaminjkraft @csilvers @StevenACoffman