-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Redo makefile to inject version, fix snapshots, update docs #129
Redo makefile to inject version, fix snapshots, update docs #129
Conversation
Signed-off-by: Steve Coffman <steve@khanacademy.org>
I'll wait to see if ben wants to comment on this -- in general I'm happy to keep ben as the main maintainer if he wants to be! I'm not sure what thoughts he had. I will point out that this doesn't do anything for our use at Khan, which runs genqlient using |
@benjaminjkraft What are your thoughts? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps I misunderstood -- you could explain more in the PR message -- but this seems very incomplete since the recommended way to run genqlient is go run
? I don't think telling people to do //go:generate go run ... -ldflags ...
really worth it, I think we should either fix the runtime.BuildInfo
method or just put a version const in the source.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(Just to get off my queue)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(Also requesting changes to get this PR off my queue.)
1.18 adds simpler ways to do this! |
I broke this out of #127 so this is my first stacked diff.
go run
-ingmake help
and advice from https://tech.davis-hansson.com/p/make/This presumes that we want to continue to maintain a Makefile. If we want to use Mage I would be more than happy to do that instead, as Mage would probably work better on a windows machine that didn't have WSL installed.