Skip to content
This repository has been archived by the owner on May 18, 2023. It is now read-only.

Downgrade to husky v4 #456

Merged
merged 1 commit into from
Mar 26, 2021
Merged

Downgrade to husky v4 #456

merged 1 commit into from
Mar 26, 2021

Conversation

somewhatabstract
Copy link
Member

Summary:

The prepare script added by husky causes yarn to be re-entrant in its installs, which can lead to the same tarball being unpacked more than once at the same time, corrupting itself

See yarnpkg/yarn#6312 and yarnpkg/yarn#2629

Issue: none

Test plan:

yarn test

When we deploy to gcloud, it should deploy.

The prepare script added by husky causes yarn to be re-entrant in its installs, which can lead to the same tarball being unpacked more than once at the same time, corrupting itself

See yarnpkg/yarn#6312 and yarnpkg/yarn#2629
@somewhatabstract somewhatabstract requested a review from a team March 26, 2021 18:08
@somewhatabstract somewhatabstract self-assigned this Mar 26, 2021
@codecov
Copy link

codecov bot commented Mar 26, 2021

Codecov Report

Merging #456 (06e028c) into master (2769efc) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #456   +/-   ##
=======================================
  Coverage   99.54%   99.54%           
=======================================
  Files          51       51           
  Lines         664      664           
  Branches      128      128           
=======================================
  Hits          661      661           
  Misses          3        3           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2769efc...06e028c. Read the comment docs.

@somewhatabstract somewhatabstract merged commit 7465834 into master Mar 26, 2021
@somewhatabstract somewhatabstract deleted the downgradehusky branch March 26, 2021 18:43
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants