-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Publish GLSL_EXT_integer_dot_product #195
base: main
Are you sure you want to change the base?
Conversation
I wonder if there is currently good and handy type conversion function for packed4x8 type in integer_dot_product, like packHalf2x16() unpackHalf2x16() for packed fp16. Existing conversions such as packSnorm4x8() will lose precision due to norm and are not suitable for use in computational tasks. A common scenario: I admit that we could simulate this pack/unpack process with bit shift/or/and operations, but doing so is complex and limited and can be inefficient |
263e5f3
to
5e827e0
Compare
Currently no, I don't think there is. One could be added but ...
I'm not sure why you say that they are limited, so perhaps you have something different in mind, but compilers should already understand that these are pack/unpack operations and be emitting good instruction sequences for them. I don't think we should expect any gain in efficiency from adding functions for this. |
Signed-off-by: Kevin Petit <kevin.petit@arm.com> Change-Id: Ifc55b44217819cf5c6998eeb4aedcc8d7597e65d
Signed-off-by: Kevin Petit <kevin.petit@arm.com> Change-Id: I67df435e5da65af460bacc40d5cba2379859516e
Signed-off-by: Kevin Petit <kevin.petit@arm.com>
5e827e0
to
8f73267
Compare
Thanks for the fixes. What's the state of implementations on this? Is it ready to be merged now? |
Thanks for the review! As far as I'm aware there are two prototypes from two different people, neither of which is complete. Neither author is able to continue work on their implementation. I expect this to be discussed in today's Vulkan ML teleconference and hopefully someone will be able to pick up the work. We could wait until we have a complete implementation to merge just in case implementation work turns up spec issues but I think this spec has been reviewed a good number of times by now so maybe publishing is helpful. I don't feel too strongly either way. |
When resolving conflicts, please note that you will also need to move any changes in this branch to README.md, to corresponding asciidoc markup in README.adoc, and remove README.md . |
Signed-off-by: Kevin Petit kevin.petit@arm.com
Change-Id: Ifc55b44217819cf5c6998eeb4aedcc8d7597e65d