Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tests for CLI errors when ASTC options are specified with non-ASTC format #12

Merged
merged 1 commit into from
Dec 4, 2023
Merged

Tests for CLI errors when ASTC options are specified with non-ASTC format #12

merged 1 commit into from
Dec 4, 2023

Conversation

aqnuep
Copy link
Collaborator

@aqnuep aqnuep commented Dec 4, 2023

@aqnuep aqnuep requested a review from MarkCallow December 4, 2023 09:02
@aqnuep aqnuep mentioned this pull request Dec 4, 2023
Merged
MarkCallow
MarkCallow reviewed Dec 4, 2023
View reviewed changes
Copy link
Collaborator

@MarkCallow MarkCallow left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests look good but shouldn't we have tests that tests the options aren't rejected when the format is an ASTC format? Oh! those probably already exist but don't show up in the diffs shown in this PR.

@aqnuep
Copy link
Collaborator Author

aqnuep commented Dec 4, 2023

Tests look good but shouldn't we have tests that tests the options aren't rejected when the format is an ASTC format? Oh! those probably already exist but don't show up in the diffs shown in this PR.

Yes, we have tests that already cover that. Really, we only missed the negative CLI options tests for these, which allowed this bug to slip through.

@MarkCallow
Copy link
Collaborator

Yes, we have tests that already cover that.

Okay. I'll merge this.

@MarkCallow MarkCallow merged commit a48547d into KhronosGroup:main Dec 4, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarkCallow MarkCallow MarkCallow left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aqnuep @MarkCallow