Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disallow ASTC options when format is not ASTC #809

Merged
merged 1 commit into from
Dec 7, 2023

Conversation

aqnuep
Copy link
Collaborator

@aqnuep aqnuep commented Nov 30, 2023

Fixes #808.

CTS test cases will come once @MarkCallow fixes the regression with the golden file regeneration.

@aqnuep
Copy link
Collaborator Author

aqnuep commented Dec 4, 2023

CTS PR KhronosGroup/KTX-Software-CTS#12 created and should be merged before updating the CTS ref of this PR.

@aqnuep aqnuep marked this pull request as ready for review December 4, 2023 18:23
@aqnuep
Copy link
Collaborator Author

aqnuep commented Dec 4, 2023

Updated CTS reference, this one should be ready to go.

@MarkCallow
Copy link
Collaborator

Ping @lexaknyazev. Please review.

@aqnuep aqnuep mentioned this pull request Dec 6, 2023
@MarkCallow MarkCallow merged commit d3ef5ed into KhronosGroup:main Dec 7, 2023
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create should verify ASTC options and the format provided
2 participants