[Backport to 17] Fix image access in link-attribute test (#2598) #2611
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…p#2598) The test performed a read_image operation on an image declared `write_only`. `spirv-val` recently started flagging this. Update the image access attribute to "read-only" (i.e., 0). Fixes KhronosGroup#2597 (cherry picked from commit bd0fffe)
|
This backport fixes check-llvm-spirv on llvm_release_170 branch |
svenvh
approved these changes
Jun 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test performed a read_image operation on an image declared
write_only.spirv-valrecently started flagging this.Update the image access attribute to "read-only" (i.e., 0).
Fixes #2597
(cherry picked from commit bd0fffe)