Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Image validation in unit test #2597

Closed
alan-baker opened this issue Jun 7, 2024 · 0 comments · Fixed by #2598
Closed

Image validation in unit test #2597

alan-baker opened this issue Jun 7, 2024 · 0 comments · Fixed by #2598

Comments

@alan-baker
Copy link

https://github.com/KhronosGroup/SPIRV-LLVM-Translator/blob/main/test/link-attribute.ll started failing after updating SPIRV-Tools to include KhronosGroup/SPIRV-Tools#5695. That change added some missing validation that checks that the image types in OpSampledImage are consistent.
svenvh added a commit to svenvh/SPIRV-LLVM-Translator that referenced this issue Jun 7, 2024
@svenvh
Fix image access in link-attribute test
947a50f 
The test performed a read_image operation on an image declared
`write_only`.  `spirv-val` recently started flagging this.

Update the image access attribute to "read-only" (i.e., 0).

Fixes KhronosGroup#2597
@svenvh svenvh mentioned this issue Jun 7, 2024
Merged
@svenvh svenvh closed this as completed in bd0fffe Jun 13, 2024
jsji pushed a commit to intel/llvm that referenced this issue Jun 27, 2024
@svenvh @sys-ce-bb
Fix image access in link-attribute test (#2598)
09dea92 
The test performed a read_image operation on an image declared
`write_only`.  `spirv-val` recently started flagging this.

Update the image access attribute to "read-only" (i.e., 0).

Fixes KhronosGroup/SPIRV-LLVM-Translator#2597

Original commit:
KhronosGroup/SPIRV-LLVM-Translator@bd0fffe337d27b3
wenju-he pushed a commit to wenju-he/SPIRV-LLVM-Translator that referenced this issue Jun 28, 2024
@svenvh @wenju-he
[Backport to 18] Fix image access in link-attribute test (KhronosGrou…
717f488 
…p#2598)

The test performed a read_image operation on an image declared
`write_only`.  `spirv-val` recently started flagging this.

Update the image access attribute to "read-only" (i.e., 0).

Fixes KhronosGroup#2597

(cherry picked from commit bd0fffe)
@wenju-he wenju-he mentioned this issue Jun 28, 2024
Merged
wenju-he pushed a commit to wenju-he/SPIRV-LLVM-Translator that referenced this issue Jun 28, 2024
@svenvh @wenju-he
[Backport to 17] Fix image access in link-attribute test (KhronosGrou…
b661a0e 
…p#2598)

The test performed a read_image operation on an image declared
`write_only`.  `spirv-val` recently started flagging this.

Update the image access attribute to "read-only" (i.e., 0).

Fixes KhronosGroup#2597

(cherry picked from commit bd0fffe)
@wenju-he wenju-he mentioned this issue Jun 28, 2024
Merged
svenvh added a commit that referenced this issue Jun 28, 2024
@wenju-he @svenvh
[Backport to 17] Fix image access in link-attribute test (#2598) (#2611)
b9dab20 
The test performed a read_image operation on an image declared
`write_only`.  `spirv-val` recently started flagging this.

Update the image access attribute to "read-only" (i.e., 0).

Fixes #2597

(cherry picked from commit bd0fffe)

Co-authored-by: Sven van Haastregt <sven.vanhaastregt@arm.com>
svenvh added a commit that referenced this issue Jun 28, 2024
@wenju-he @svenvh
[Backport to 18] Fix image access in link-attribute test (#2598) (#2610)
3e602b4 
The test performed a read_image operation on an image declared
`write_only`.  `spirv-val` recently started flagging this.

Update the image access attribute to "read-only" (i.e., 0).

Fixes #2597

(cherry picked from commit bd0fffe)

Co-authored-by: Sven van Haastregt <sven.vanhaastregt@arm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix image access in link-attribute test svenvh/SPIRV-LLVM-Translator
1 participant
@alan-baker