OpSampledImage extra validation #5695
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
alan-baker
commented
May 31, 2024
alan-baker
commented
- Validate that the type of Image operand matches the result type's Image operand
* Validate that the type of Image operand matches the result type's Image operand
s-perron
approved these changes
May 31, 2024
|
Smoketests fail because glslang's HLSL compilation emits inconsistent image types for the sample operation. DXC for example sets the Depth operand to 2, but glslang emits 0 or 1 (at def and use respectively). |
This was referenced Jun 3, 2024
This was referenced Aug 20, 2024
alan-baker
added a commit
that referenced
this pull request
Sep 4, 2024
This reverts commit 70ad4da.
alan-baker
added a commit
that referenced
this pull request
Sep 4, 2024
Keenuts
pushed a commit
to Keenuts/SPIRV-Tools
that referenced
this pull request
Nov 12, 2024
…Group#5785) This reverts commit 70ad4da. Contributes to KhronosGroup#5781 SPIR WG 2024-09-04: decision to relax validation requirement in the spec.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.